Fix bug with --node-count arg for worker.#701
Merged
christophertubbs merged 1 commit intoNOAA-OWP:masterfrom Aug 16, 2024
Merged
Fix bug with --node-count arg for worker.#701christophertubbs merged 1 commit intoNOAA-OWP:masterfrom
christophertubbs merged 1 commit intoNOAA-OWP:masterfrom
Conversation
Fixing bug determining the correct value for the --node-count arg passed to job worker entrypoint script, which was counting allocations rather than the number of CPUs across the allocations.
christophertubbs
approved these changes
Aug 16, 2024
Contributor
christophertubbs
left a comment
christophertubbs
left a comment
There was a problem hiding this comment.
You had me at "one assignment per line"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small bug found during testing of #675, but an independent issue unto itself.
The changes allows for the Launcher object to determine the correct value for the
--node-countarg passed to job worker entrypoint script when starting services for a job. Prior to this change, the Launcher obtains this value simply by counting allocations. With this change, it will correctly use the sum of thecpu_countvalues for all allocations for the job.